Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions of outdated GHA #3640

Merged
merged 1 commit into from Nov 23, 2022
Merged

Update versions of outdated GHA #3640

merged 1 commit into from Nov 23, 2022

Conversation

abravalheri
Copy link
Contributor

Summary of changes

  • Update versions of:
    • actions/checkout
    • actions/setup-python
    • cygwin/cygwin-install-action

Closes

Pull Request Checklist

webknjaz
webknjaz reviewed Oct 19, 2022
View reviewed changes
.github/workflows/main.yml
- name: Install OS-level dependencies
run: |
sudo apt-get update
sudo apt-get install build-essential gfortran libopenblas-dev
- name: Setup Python
uses: actions/setup-python@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I included the same in #3643

@edmorley
Copy link
Contributor

Dependabot supports keeping these up to date, if that's of interest longer term?
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem

@abravalheri
Copy link
Contributor Author

Hi @edmorley that sounds interesting. I think we can discuss this in the template repository (jaraco/skeleton)

@webknjaz
Copy link
Member

I think we can discuss this in the template repository (jaraco/skeleton)

Extra points to bring up:

  1. Frequent updates are annoying
  2. Dependabot is able to bump commit shas that correspond to the version tags too

So having it may work against the idea of having a skeleton (because the updates would not be as straightforward).

@abravalheri abravalheri mentioned this pull request Nov 11, 2022
Closed
2 tasks
@abravalheri abravalheri merged commit 8f2cf58 into pypa:main Nov 23, 2022
@abravalheri abravalheri deleted the update-gha branch November 23, 2022 14:49
@abravalheri
Copy link
Contributor Author

For the time being I am just doing the minimal update and merging this change.

I will defer the discussion regarding automatic updates to jaraco/skeleton (maybe Jason will have some insights about it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abravalheri @edmorley @webknjaz