Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Typo in Dependency Management pyproject.toml #3554

Merged
merged 4 commits into from Aug 24, 2022

Conversation

mfbutner
Copy link
Contributor

@mfbutner mfbutner commented Aug 21, 2022

Under the Dependency Management pyproject.toml example, requests was mistyped as requires.

Summary of changes

Closes

Pull Request Checklist

@abravalheri
Copy link
Contributor

Thank you very much @mfbutner.

requires is also a valid dependency, but I guess requests can be less confusing for starters.

@abravalheri abravalheri merged commit 785646c into pypa:main Aug 24, 2022
@mfbutner
Copy link
Contributor Author

Thanks for letting me know that requires is also valid. I thought it was a typo because the corresponding examples for setup.py and setup.cfg use requests and requests was used in the other examples throughout the page that use dependencies.

@abravalheri
Copy link
Contributor

Yeah, having all the dependencies on the same page being equivalent is a nice touch. I agree that using requests makes the docs less confusing for the users.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants