Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editable finder: Avoid recursion when missing module has the same name as parent #3551

Merged
merged 4 commits into from Aug 21, 2022
Merged

Editable finder: Avoid recursion when missing module has the same name as parent #3551

merged 4 commits into from Aug 21, 2022

Conversation

abravalheri
Copy link
Contributor

Summary of changes

  • Ensure that the finder will not result in circular imports when a missing module coincidentally has the same name as its parent module.

Closes #3550.

Pull Request Checklist

@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Aug 21, 2022
Closed
@abravalheri abravalheri marked this pull request as ready for review August 21, 2022 05:57
@abravalheri abravalheri merged commit 209d497 into pypa:main Aug 21, 2022
@abravalheri abravalheri deleted the issue-3550 branch August 21, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Realtive import of nonexistent package with same name throws RecursionError
1 participant
@abravalheri