Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the package_dir configuration #3358

Merged
merged 7 commits into from Jun 11, 2022
Merged

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Jun 10, 2022

Summary of changes

  • Expand on the summary about package_dir in the Keywords page to make it more clear what this configuration parameter does.

Closes #3357

Pull Request Checklist

@abravalheri abravalheri marked this pull request as ready for review June 10, 2022 12:19
docs/references/keywords.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@cdfarrow cdfarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This is what I have been looking for. I've just made a few grammar tweaks.

docs/userguide/declarative_config.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
docs/userguide/declarative_config.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
docs/references/keywords.rst Outdated Show resolved Hide resolved
Co-authored-by: cdfarrow <cdfarrow@users.noreply.github.com>
@abravalheri
Copy link
Contributor Author

Thank you very much for the review and improvements @cdfarrow!

@abravalheri abravalheri merged commit fbe659b into pypa:main Jun 11, 2022
@abravalheri abravalheri deleted the issue-3357 branch June 11, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Provide fuller explanation of package_dir semantics
2 participants