Make test_setup_install_includes_dependencies work with custom PYTHONPATH set #3336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the same reasoning as in #3133 -- the test imported the previously installed setuptools version in our environment and since that version did not yet use
__EASYINSTALL_INDEX
, it reached https://pypi.org/simple/ instead. That way, we recognized it as a problem. If the installed version had already used__EASYINSTALL_INDEX
, we would probably never realize that it is the installed version that is being tested here.The three individual commits follow my train of thoughts, so I preserved them here separated, for easier review.
pytest.raises
detour -- happy to revert if there was a reason for it$PYTHONPATH
value instead of overriding it, making it actually work in our environmentinstall_root
to$PYTHONPATH
is not necessary for this test, so I removed it -- happy to squash that to the previous one if you prefer thatThanks.