Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced single backticks with double ones #3331

Merged
merged 2 commits into from May 20, 2022
Merged

Conversation

codeandfire
Copy link
Contributor

@codeandfire codeandfire commented May 19, 2022

Summary of changes

These two items ** and package_data in the CHANGES.rst file were being identified as links rather than code due to the single backticks.
In turn leading to Sphinx emitting warnings about this and the docs failing to build.

Closes: No issue that I am aware of? However these warnings were preventing the docs from building on my machine.

Pull Request Checklist

  • News fragment added in [changelog.d/].

These two items `**` and `package_data` were being identified as links
rather than code due to the single backticks.
In turn leading to Sphinx emitting warnings about this and the docs
failing to build.
@codeandfire codeandfire marked this pull request as ready for review May 19, 2022 19:52
@abravalheri
Copy link
Contributor

Good catch! Thank you very much.

@abravalheri abravalheri merged commit 4ad3d45 into pypa:main May 20, 2022
@codeandfire codeandfire deleted the fix-1 branch May 20, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants