Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one-line summary to some warnings #3328

Merged
merged 6 commits into from May 18, 2022

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented May 18, 2022

Summary of changes

  • Improve first line of some warning messages to address Gentoo's reporting
    problems, see e66ee62#r73907648

Closes

Pull Request Checklist

abravalheri referenced this pull request May 18, 2022
@abravalheri abravalheri changed the title Online summary warnings Add one-line summary to some warnings May 18, 2022
Copy link
Contributor

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

setuptools/command/build_py.py Outdated Show resolved Hide resolved
setuptools' `packages` configuration field or the proper discovery methods.
setuptools' `packages` configuration field or the proper discovery methods
(for example by using `find_namespace_packages(...)`/`find_namespace:`
instead of `find_packages(...)`/`find:`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this clarification!

Co-authored-by: Michał Górny <mgorny@gentoo.org>
@abravalheri abravalheri marked this pull request as ready for review May 18, 2022 14:12
@abravalheri abravalheri merged commit 344512a into pypa:main May 18, 2022
@abravalheri abravalheri deleted the online-summary-warnings branch May 18, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants