Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with pypa/distutils@a7cfb56a7 #3311

Merged
merged 20 commits into from May 10, 2022
Merged

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented May 9, 2022

  • Detect when a venv is created from an in-tree build. Fixes Missing license #132
  • make all fields documented as optional in the spec truly optional (dont warn when omitted), and stop coercing missing values to the string "UNKNOWN"
  • Extract check for 'd is None'.
  • Combine logic between prefix and base_prefix.
  • Adapt style
  • Simply emit the expected value instead of converting to an exit code and deciphering.
  • Rely on jaraco.envs for environment creation.
  • Prefer tabs
  • Use pass_none decorator.
  • Prefer tox 3.25 with built-in support for Windows env vars.
  • Run tests using tox, even on cygwin.
  • Prefer tabs
  • address review comments
  • fix a typo
  • Update changelog

Summary of changes

Closes

Pull Request Checklist

@jaraco jaraco force-pushed the feature/distutils-a7cfb56a7b1eaa branch from 52cd03d to 9afdc03 Compare May 10, 2022 11:48
@jaraco
Copy link
Member Author

jaraco commented May 10, 2022

Tests for cygwin are failing because the "tox" command is not found. That's strange and surprising because I'm using the same technique for installing and invoking tox as is used by distutils.

@jaraco
Copy link
Member Author

jaraco commented May 10, 2022

Apparently Python 3.9 is required for tox to get installed in the path. Not sure why.

@jaraco jaraco merged commit 5c660fb into main May 10, 2022
@jaraco jaraco deleted the feature/distutils-a7cfb56a7b1eaa branch May 10, 2022 13:19
@DWesl
Copy link
Contributor

DWesl commented Jun 8, 2022

Apparently Python 3.9 is required for tox to get installed in the path. Not sure why.

The /usr/bin/tox script gets installed by each of python35-tox, python36-tox, python37-tox, python38-tox, and python39-tox in turn, but can only be a part of one of those packages. The maintainer usually chooses the last one, to match the shebang line in the script. I tend to use python -m pytest to avoid needing to know which package the script got installed in, and updating everything when it gets moved (say, when Cygwin adds python 3.10 and makes that the default for command-line scripts).

If you want to find the discussion on the mailing list, I think the script that most recently got mentioned was /usr/bin/sphinx-build moving from python3-sphinx (replaced by python36-sphinx) to python38-sphinx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing license
6 participants