Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine keyword documentation #3307

Merged
merged 13 commits into from May 16, 2022
Merged

Combine keyword documentation #3307

merged 13 commits into from May 16, 2022

Conversation

ucodery
Copy link
Contributor

@ucodery ucodery commented May 5, 2022

Summary of changes

Merge differing descriptions in references/keywords and userguide/keywords and then link the userguide to references.

Closes #3254
Closes #2795

Pull Request Checklist

  • News fragment added in [changelog.d/].

@abravalheri
Copy link
Contributor

abravalheri commented May 6, 2022

Thank you very much @ucodery for working on this. I have a few suggestions, maybe it is just easier if I send a PR to your fork:

ucodery#1.

abravalheri and others added 10 commits May 6, 2022 10:30
It seems that setuptools currently uses its own mechanism for downloading
dependencies (setuptools/package_index.py).
Due to extra new lines some entries were interpreted by the rst parser
as quoted blocks. This change fixes that.
This way we can reference them.
The biggest value of retaining the `userguide/keywords` document is to
retain information about which keywords have changed.

Therefore it makes sense to preserve (and highlight) that information.
Suggestions for improvements over PR 3307
@abravalheri
Copy link
Contributor

Thank you very much for the updates Jeremy! ❤️ 💚

@abravalheri
Copy link
Contributor

It is been a while this documentation update has been proposed, so I think we can merge it now.

If any member of the community, thinks about a better way of organising it, a follow up PR can be used :)

Thank you very much @ucodery!

@abravalheri abravalheri merged commit 508d61c into pypa:main May 16, 2022
@ucodery ucodery deleted the kwargs branch May 16, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants