Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional metadata sans distutils #3299

Merged
merged 1 commit into from May 9, 2022
Merged

Optional metadata sans distutils #3299

merged 1 commit into from May 9, 2022

Conversation

wimglenn
Copy link
Contributor

@wimglenn wimglenn commented Apr 30, 2022

Same as #3289 but without the changes under _distutils (companion to pypa/distutils#138).

…uplicates on PyPI). prevent "UNKNOWN" vals from appearing in summary, license, platform. prevent an extra newline getting added in long description
@abravalheri
Copy link
Contributor

I would still wait for the changes to land in distutils (and then merged back in setuptools) before merging this PR, otherwise the end result will be warnings that don't make sense (or are even conceptually wrong) for the the user and a bad UX.

If all the merges happen, we are going with situation 2 described in #3289 (comment)

@jaraco jaraco mentioned this pull request May 9, 2022
@jaraco
Copy link
Member

jaraco commented May 9, 2022

I would still wait for the changes to land in distutils (and then merged back in setuptools) before merging this PR, otherwise the end result will be warnings that don't make sense (or are even conceptually wrong) for the the user and a bad UX.

I'll plan to merge these all in the same day and avoid that experience.

If all the merges happen, we are going with situation 2 described in #3289 (comment)

[if the user has set SETUPTOOLS_USE_DISTUTILS=stdlib], they will see some warnings that will not make sense (and even be conceptually unjustified), but the build will ultimately pass. That is a bad UX. Maybe we can see the bad UX in this case as a compromise?

I'd like to deprecate SETUPTOOLS_USE_DISTUTILS=stdlib soon, so that seems like a fair compromise. We may have to back out some of these warnings if they cause unmanageable disruption.

@jaraco jaraco merged commit 6d5cf0d into pypa:main May 9, 2022
jaraco added a commit that referenced this pull request May 9, 2022
@wimglenn wimglenn deleted the optional-metadata-2 branch May 9, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants