Merge distutils at 5229dad46b #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jaraco
commented
Apr 10, 2022
•
jaraco
commented
- Fix EXT_SUFFIX for windows py<3.8
- Fix SO too
- Move EXT_SUFFIX support to _py39compat, to be removed after support for Python 3.9 is dropped. Fall back to default behavior on Python 3.10. Remove functionality for SO, which has been long deprecated and is untested.
- 👹 Feed the hobgoblins (delint).
- Just modify the vars in place.
- Restore expectation that SO matches EXT_SUFFIX with rationale.
- Get the version logic correct.
- Move compatibility concerns out of the function to do the adding.
- Emit warning after parsing. Fixes The warning in (Loose)Version is emitted before __repr__ works distutils#122.
- Disable installation of Setuptools in tox instead of GHA. Ref Tests fail when tox/virtualenv installs setuptools 60+ distutils#99.
- Use cache_tag in default build_platlib dir
- Skip test_get_makefile_filename on non-CPython
- Update test_home_installation_scheme for pypy install paths
- Refactor as simple replace. If a full string substitution proves to be necessary, let's create a mapping.
…or Python 3.9 is dropped. Fall back to default behavior on Python 3.10. Remove functionality for SO, which has been long deprecated and is untested.
Fix EXT_SUFFIX for windows py<3.8
Use `sys.implementation.cache_tag` instead of Python version to create the default directory for `build_platlib`. This guarantees that the directories used by CPython and PyPy are distinct. Prior to the change, both CPython and PyPy would use e.g. `lib.linux-x86_64-3.9`. With the change, they are going to use `lib.linux-x86_64-cpython39` and `lib.linux-x86_64-pypy39` respectively.
The Makefile is specific to CPython and does not exist e.g. on PyPy installs. Skip the test appropriately.
…e necessary, let's create a mapping.
Update test_home_installation_scheme for pypy install paths
Use cache_tag in default build_platlib dir
Skip test_get_makefile_filename on non-CPython
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.