Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[follow-up auto-discovery] Simplify package_dir #3249

Merged
merged 3 commits into from Apr 6, 2022

Conversation

abravalheri
Copy link
Contributor

Summary of changes

  • If the directory follows a src-layout-ish, try harder to make package_dir in the form {"": "src"}.

This might be later important for PEP 660 (e.g. when composing pth files or symlinking the top-level packages).

Closes

Pull Request Checklist

If the directory follows a src-layout-ish, try harder to
make `package_dir` in the form `{"": "src"}`.

This might be later important for PEP 660 (e.g. when composing pth
files or symlinking the toplevel packages).
@abravalheri abravalheri marked this pull request as ready for review April 5, 2022 11:00
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abravalheri abravalheri merged commit e5552d3 into pypa:main Apr 6, 2022
@abravalheri abravalheri deleted the simplify-package-dir branch April 6, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants