Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge with distutils@e1d5c9b1f6 #3224

Merged
merged 17 commits into from
Mar 27, 2022
Merged

Merge with distutils@e1d5c9b1f6 #3224

merged 17 commits into from
Mar 27, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Mar 27, 2022

  • Don't warn on false positive for author/maintainer's email
  • 👹 Feed the hobgoblins (delint).
  • Rewrite docstring for imperative voice and proper structure.
  • Move 'updated_files' operation outside of if statement as it appears in both branches unconditionally.
  • Extract method for copying a file.
  • Remove outfiles, unused.
  • Extract _change_modes and _change_mode functions.
  • Rewrite the comment to match the implementation.
  • Use 'shebang_' for pattern and match.
  • Extract method to validate the shebang.
  • Restore Setuptools compatibility.
  • In build_scripts, open scripts as text. Fixes [BUG] build_scripts.py incorrectly handles shebang lines with DOS line endings distutils#124.

Summary of changes

Closes

Pull Request Checklist

abravalheri and others added 17 commits February 23, 2022 11:24
@abravalheri
Don't warn on false positive for author/maintainer's email
05c961b 
While I was working to support pyproject.toml metadata in setuptools,
I received as a feedback from the community[^1] that setuptools
warns the following message when `author_email` and `maintainer_email`
are given in the form of `Person Name <email@address>`:

> warning: check: missing meta-data: either (author and author_email)
> or (maintainer and maintainer_email) should be supplied

This can be seen as a false positive, because indeed both author's name
and email are provided.

This warning seems to happen because distutils define the `check`
command as a subcommand for `sdist`.

This change aims to remove this false positive result from the checks.

[^1]: https://discuss.python.org/t/help-testing-experimental-features-in-setuptools/13821/18
@jaraco
Merge pull request #116 from abravalheri/fix-check-warning
61bc807 
Prevent warn on false positive for author/maintainer's email
@jaraco
👹 Feed the hobgoblins (delint).
b16cf40
@jaraco
Rewrite docstring for imperative voice and proper structure.
6736459
@jaraco
Move 'updated_files' operation outside of if statement as it appears …
beefbe7 
…in both branches unconditionally.
@jaraco
Extract method for copying a file.
fe5e02d
@jaraco
Remove outfiles, unused.
d80e720
@jaraco
Extract _change_modes and _change_mode functions.
f91759e
@jaraco
Rewrite the comment to match the implementation.
afaf3c0
@jaraco
Use 'shebang_' for pattern and match.
6a7d01c
@jaraco
Extract method to validate the shebang.
12edb8d
@jaraco
Restore Setuptools compatibility.
7038cf2
@jaraco
Merge pull request #128 from pypa/feature/refactor-build-scripts
3663538 
Refactor build scripts
@jaraco
In build_scripts, open scripts as text. Fixes pypa/distutils#124.
e2f47dc
@jaraco
Merge pull request #129 from pypa/feature/scripts-text
e1d5c9b 
In build_scripts, open scripts as text.
@jaraco
Merge https://github.com/pypa/distutils into feature/distutils-e1d5c9…
247b051 
…b1f6
@jaraco
Update changelog
a0148a1
@jaraco jaraco merged commit 16964dd into main Mar 27, 2022
@jaraco jaraco deleted the feature/distutils-e1d5c9b1f6 branch March 27, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] build_scripts.py incorrectly handles shebang lines with DOS line endings
2 participants
@jaraco @abravalheri