Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing requirements with pyproject.toml #3223

Merged
merged 10 commits into from
Mar 27, 2022
Merged

Fix missing requirements with pyproject.toml #3223

merged 10 commits into from
Mar 27, 2022

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Mar 27, 2022 •
edited

Summary of changes

  • Fixed missing requirements with environment markers when
    optional-dependencies is set in pyproject.toml.
  • Attempt to reduce verbosity by ignoring pyproject.tom when trying to install setup_requires.

Closes #3204

Pull Request Checklist

@abravalheri abravalheri marked this pull request as ready for review March 27, 2022 15:45
@abravalheri abravalheri merged commit 2582a8b into pypa:main Mar 27, 2022
@abravalheri abravalheri deleted the issue-3203 branch March 27, 2022 16:32
@abravalheri abravalheri mentioned this pull request May 4, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [pyproject.toml] Requirements with markers are ignored if project.optional-dependencies is set
1 participant
@abravalheri