[pyproject.toml] Temporarily warn about improper backfilling without dynamic
#3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With emphasis on the ``dynamic`` behaviour
- PEP 621 requires the build backend to not backfill values without dynamic. - Some users seem to been writing ``pyproject.toml`` with a "partial" ``[project]`` table even before setuptools added support for pyproject metadata. In several cases this table is incomplete and the real metadata lives either in ``setup.py`` or ``setup.cfg``. To avoid ignoring metadata in these scenarios and resulting in failing builds, the change implemented here adopts a more "forgiving" posture and warns an informative message during the transition period.
Issues 3195 and 3204 surface the fact that setuptools may need to allow dynamic values to be computed by the users in the ``setup.py`` file (e.g. if they need to dynamically decide dependencies based on the host machine in a way that is not supported by environment markers, such as GPU presence). The current implementation somehow already allows that by layering the configs `setup.py` > `setup.cfg` > `pyproject.toml`. However this is done without having in mind the limitations about `dynamic` imposed by PEP 621. The change implemented here tries to fix this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
pyproject.tomlwith a[project]table, but at the same time it is trying to set other configs via other files (e.g.setup.py), without settingdynamicproperlypyproject.tomlmetadata stabilises), instead of warning, setuptools should fail.Closes #3195
Pull Request Checklist
changelog.d/.(See documentation for details)