Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependencies with setup.py install #3212

Merged
merged 8 commits into from
Mar 26, 2022

Conversation

abravalheri
Copy link
Contributor

Summary of changes

  • Fix condition in the setuptools.command.install to detect whether the command was called directly from setup() or by another command.

Closes #3198

Pull Request Checklist

Starting in v61, setuptools.dist overwrites distutils.dist.run_command
to add auto-discovery functionality on top of the original
implementation.

This change modifies the existing code in setuptools.command.install to
consider that previous change when trying to decide if the install
command was called directly from `setup.py` or not.
@abravalheri abravalheri marked this pull request as ready for review March 26, 2022 07:43
@abravalheri abravalheri merged commit a23f983 into pypa:main Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 61.0.0 breaks "setup.py install" by missing dependencies in install_requires
1 participant