Remove more_itertools.more from vendored libs (fixes pypa/setuptools#3090) #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Feb 8, 2022
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
jaraco
reviewed
Feb 8, 2022
tools/vendored.py
Outdated
| """ | ||
| Rewrite more_itertools to remove unused more_itertools.more | ||
| """ | ||
| for more_file in pkg_files.glob("more.py*"): |
There was a problem hiding this comment.
Instead of glob, just use pkg_files.joinpath('more.py') and apply the changes to that.
There was a problem hiding this comment.
The intent was to remove also associated *.pyi files to prevent typechecker (and possibly also smart editors) from believing the removed content is still there
| 'UnequalIterablesError', | ||
| 'adjacent', | ||
| 'all_unique', | ||
| 'always_iterable', |
There was a problem hiding this comment.
I'm expecting to use this function sooner than later as it satisfies a common pattern.
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
maciejp-ro
force-pushed
the
remove-more_itertools.more
branch
from
c8464bf
to
44b39e0
Compare
|
I have confirmed that lazy import also fixes gevent freeze, PR updated |
|
Thanks for the fix. Releasing as v60.8.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Remove
more_itertools.morefrom vendoredmore_itertools, which is unused, large, and breaks gevent by importingconcurrent.futures.threading(see gevent/gevent#1865).Closes #3090
Files in vendored
.dist-infodirectory still refer to removed files, I'm assuming it's not a problem because other modifications intools/vendored.pydon't update the checksums.Pull Request Checklist
changelog.d/.(See documentation for details)