Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress distutils replacement when building or testing CPython. #3031

Merged
merged 1 commit into from Jan 17, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jan 16, 2022

Fixes #2965. Fixes #3007.

@jaraco jaraco force-pushed the feature/cpython-suppress-distutils branch from 999358b to 336facd Compare January 16, 2022 23:22
@jaraco
Copy link
Member Author

jaraco commented Jan 16, 2022

As I was exploring this issue, I first sought to detect both the presence of 'pybuilddir.txt' and whether invoked by 'setup.py', but that would only work for 3007 and not 2965. Tests can be invoked a number of ways, through '-m unittest discover', invocation of 'regrtest.py', invocation of '-m test', and by executing the test modules directly (and maybe more). So I've opted to rely on the less precise simple detection of 'pybuilddir.txt' in the cwd. This approach won't work if the build is executed not from the root of the repo, but that seems like a small concession to make to address the issue broadly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant