Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Avoid depdencies with URLs in setup.cfg #2880

Closed
1 task done
abravalheri opened this issue Nov 14, 2021 · 0 comments · Fixed by #2882
Closed
1 task done

[BUG] Avoid depdencies with URLs in setup.cfg #2880

abravalheri opened this issue Nov 14, 2021 · 0 comments · Fixed by #2882
Labels
bug Needs Triage Issues that need to be evaluated for severity and status.

Comments

@abravalheri
Copy link
Contributor

abravalheri commented Nov 14, 2021

setuptools version

main: d212daa

Python version

Python 3.8

OS

Ubuntu 20.04.3 LTS

Additional environment information

No response

Description

It seems that #2865 might have accidentally introduced a kind of dependency that is not accepted by PyPi:

[options.extras_require]
testing =
        ...
-	pytest-virtualenv>=1.2.7
+	pytest-virtualenv @ git+https://github.com/jaraco/pytest-plugins@distutils-deprecated#subdirectory=pytest-virtualenv

in setup.cfg.

PyPI forbids uploading packages with dependencies outside of PyPI (via URLs specs).

Expected behavior

An alternative for this implementation is to leave the previous dependency as it was in setup.cfg, but overwrite it using the deps field in tox.ini.

How to Reproduce

This problem is currently being pointed out by the CI:
https://github.com/pypa/setuptools/runs/4196605393?check_suite_focus=true
To replicate the problem it is necessary to try to submit the distribution files to PyPI

Output

HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
Invalid value for requires_dist. Error: Can't have direct dependency: "pytest-virtualenv @ git+https://github.com/jaraco/pytest-plugins@distutils-deprecated#subdirectory=pytest-virtualenv ; extra == 'testing'"
ERROR: InvocationError for command /home/runner/work/setuptools/setuptools/.tox/release/bin/python -m twine upload 'dist/*' (exited with code 1)

Code of Conduct

  • I agree to follow the PSF Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs Triage Issues that need to be evaluated for severity and status.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant