Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reliance on LegacyVersion #2822

Merged
merged 12 commits into from
Jan 16, 2023
Merged

Remove reliance on LegacyVersion #2822

merged 12 commits into from
Jan 16, 2023

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Oct 22, 2021

  • Remove use of packaging.version.LegacyVersion. Fixes Remove support for LegacyVersion #2497.
  • Add changelog. Ref Remove support for LegacyVersion #2497.
  • egg_info: avoid non-PEP440 versions from tag_date
  • package_index: don't create dists with non-PEP440 versions
  • Suppress the now invalid pbr version.
  • Update test_egg_fragment to include a name with a dash in it. Expand on interpret_distro_name to be a tiny bit smarter about inferring the pivot separating name and version.

Summary of changes

Closes #2497.

Pull Request Checklist

@pradyunsg
Copy link
Member

suggestion: When you do release this, do a major version bump.

I expect that a lot of users who will complain that this is a breaking change (because their internal $corp systems depended on non-PEP 440 versions). The answer for them can then be (a) Python has been spewing out a deprecation warning about this for months, (b) it's a major version bump; deal with it, and (c) was there anything related to this change that would have made you reach out/react to it sooner?

I'd strongly suggest asking the users what setuptools could have done to make the change less disruptive, rather than arguing whether the change is important -- the users will usually care mostly due to the immediate disruption it's caused them, and taking that moment to ask them "hey, how do you monitor for upcoming changes" is a useful exercise for both parties. :)

@pradyunsg
Copy link
Member

Wait, there was never a release which spewed out deprecation warnings?

Hmm... I think doing a major version series that does that is a worthwhile thing -- otherwise, this is basically a major change being made without any heads up to any of the downstream users; who sometimes can't control the exact version of setuptools they're using (eg: in pip's isolated build environments).

Anyway, that's my two cents. I'mma step away and let y'all decide how you wanna manage changes around this project. :)

@jaraco
Copy link
Member Author

jaraco commented Nov 1, 2021

Good idea. In #2840, I introduce such a warning. I'd expected that introducing that warning would have happened from the packaging package, but because it's vendored and pinned, that warning has been suppressed.

@jaraco jaraco marked this pull request as draft November 1, 2021 01:14
@pradyunsg
Copy link
Member

Hiya @jaraco! Anything I can do to help move this forward?

/cc @abravalheri as well. :)

@jaraco jaraco marked this pull request as ready for review January 14, 2023 16:08
@jaraco
Copy link
Member Author

jaraco commented Jan 14, 2023

The deprecation has been in place for 15 months. Let's remove support.

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a setuptools maintainer, but LGTM!

@jaraco jaraco merged commit 217d926 into main Jan 16, 2023
@jaraco jaraco deleted the debt/remove-legacy-version branch January 16, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for LegacyVersion
2 participants