Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov.yml #2762

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Update codecov.yml #2762

merged 4 commits into from
Oct 20, 2021

Conversation

tanvimoharir
Copy link
Contributor

@tanvimoharir tanvimoharir commented Aug 30, 2021

Summary of changes

This is a change to in codecov configurations to prevent failures as those seen post #2693

Closes #2727

Pull Request Checklist

@jaraco jaraco closed this Sep 4, 2021
@jaraco jaraco reopened this Sep 4, 2021
@jaraco
Copy link
Member

jaraco commented Sep 4, 2021

This change appears to change three different settings in the configuration. Can you explain the purpose of each of those settings?

@tanvimoharir
Copy link
Contributor Author

This change appears to change three different settings in the configuration. Can you explain the purpose of each of those settings?

The changes are currently adapted from the configurations initially recommended at #2727 (the main change being reducing the threshold )
These are not final and I'm still looking into details of initial failures.

@webknjaz
Copy link
Member

@tanvimoharir tanvimoharir marked this pull request as ready for review October 20, 2021 07:56
@tanvimoharir
Copy link
Contributor Author

@jaraco jaraco merged commit fee9d17 into pypa:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding codecov causes spurious PR check failures
3 participants