Distutils refresh #2653
Merged
Distutils refresh #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert blockquotes into literal blocks
…and as it would be used, restoring expectation lost in python/cpython#18743. Ref #2417 where this change was a red-herring for another issue.
Compared to /Ox, /O2 has two additional options: /GF: Eliminate Duplicate Strings /Gy: Enable Function-Level Linking Co-Authored-By: Nikita Kniazev <2743474+Kojoley@users.noreply.github.com>
Only complain if the config target is >= 10.3 and the current target is < 10.3. The check was originally added to ensure that incompatible LDSHARED flags are not used, because '-undefined dynamic_lookup' is used when building for 10.3 and later, and is not supported on older OS versions[1]. Apart from that, there should be no problem in general with using an older target. [1] python/cpython@6b08a40
Copy workflows from jaraco/skeleton. Enables CI.
bpo-41882: Clean up after CCompiler.has_function()
Use /O2 compiler option instead of /Ox for MSVC
Relax MACOSX_DEPLOYMENT_TARGET check
|
I'm confused. I only expected this PR to include a handful of these commits. I need to figure out why the whole history of distutils is appearing in the PR. |
jaraco
force-pushed
the
distutils-refresh
branch
from
4b0efa7
to
ed288d0
Compare
|
After merging #2657, the commit log is much shorter, just including the recent changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with pypa/distutils@7423f0767a.