Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed quickstart packaging resources hyperlink. #2634

Merged
merged 1 commit into from May 9, 2021

Conversation

carltongibson
Copy link
Contributor

Summary of changes

This link on the quickstart page is broken:

Screenshot 2021-04-10 at 10 15 04

The implicit link target that should have been created from the title was not
being detected correctly. This was causing the link to be interpreted as an
external hyperlink reference, resulting in a 404 in the rendered docs.

Screenshot 2021-04-10 at 10 16 03

Adding the explicit target and ref allows the link to resolve correctly.

Pull Request Checklist

I don't think these apply 馃

The implicit link target that should have been created from the title was not
being detected correctly. This was causing the link to be interpreted as an
external hyperlink reference, resulting in a 404 in the rendered docs.

Adding the explicit target and `ref` allows the link to resolve correctly.
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is the section being linked to empty? Seems like a bit of a bait and switch... 馃槄

@carltongibson
Copy link
Contributor Author

Hey @pganssle yes. 馃槂 I presumed it鈥檚 a stub for filling out anon... (not quite sure what should go there, so haven鈥檛 done the follow-up, yet)

@jaraco jaraco merged commit a41b6d9 into pypa:main May 9, 2021
@carltongibson carltongibson deleted the c/fix-quickstart-link branch May 9, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants