Fix error uploading Sphinx doc with upload_docs. Fixes #1060 #2573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #1060
Sphinx now uses
builder_target_dirs
in replacement ofbuilder_target_dir
https://github.com/sphinx-doc/sphinx/blob/3.x/sphinx/setup_command.py#L143-L145. This fix will set thetarget_dir
inupload_docs
to the path of the html builder.Note:
Upload_docs
was restored support for sites other than PyPi as noted here: https://github.com/pypa/setuptools/blob/e1ffc2abbae4f2aa78dd09ee9827d754b7702b7b/CHANGES.rst#v3610Pull Request Checklist
changelog.d/
.(See documentation for details)