Remove support for easy_install-based downloads for fetch_build_eggs #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(setup_requires).
| def fetch_build_egg(dist, req): # noqa: C901 # is too complex (16) # FIXME | ||
| """Fetch an egg needed for building. | ||
|
|
||
| Use pip/wheel to fetch/build a wheel.""" | ||
| # Check pip is available. | ||
| try: | ||
| pkg_resources.get_distribution('pip') |
There was a problem hiding this comment.
Wouldn't keeping an explicit check with pkg_resources.get_distribution('pip') make for a more user-friendly error message if pip is indeed missing?
There was a problem hiding this comment.
Perhaps, although I found in my experience that the error is "no module named pip", which seems fairly clear. More importantly, as I'd like to at some point remove the dependency on pkg_resources, I'm inclined to omit this usage here. Another advantage of this approach is that it would allow usage when 'pip' is present but its metadata is missing (for whatever reason).
benoit-pierre
approved these changes
Jan 17, 2021
jaraco
deleted the
feature/drop-fetch-build-eggs-easy-install-fallback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been deprecated since the introduction of pip-based fetch_build_eggs.