-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change documentation theme to Furo #2465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I like the idea of having a unified docs theme across the PyPA projects.
@jaraco: The ToCs are removed because the furo
theme adds its own ToC on each page, in the right sidebar, and is opinionated about not having it duplicated in the corresponding document body.
@pradyunsg: Is pradyunsg/furo@b6c7c76 released? If yes, you could close+reopen this PR to retrigger Netlify and have it build the preview.
I just closed, re-opened, and still had to manually re-deploy, but the error is emitted:
That suggests the fix is not released. Also, that commit is not present in any tags. |
Not yet, no. |
@jaraco Try redeploying now? |
@pradyunsg looks like netlify doesn't do rebuilds on reopen. Try rebasing the PR. |
This is included in the sidebar, as part of Furo.
6fb57c7
to
5c24e78
Compare
This removed the tidelift contents from the sidebar. It'd probably be a good idea to mimic how urllib3 handles the Tidelift callout: https://urllib3.readthedocs.io/en/latest/_sources/index.rst.txt, https://urllib3.readthedocs.io/en/latest/. Let me know if that's desirable and I'll amend this PR for that. :) |
Happy to mimic urllib3. I'd like to apply the changes to every tidelift-sponsored project. Let's apply the concept to jaraco/tidelift first, then I can merge the change into setuptools main. |
…ontents and borrow For Enterprise content from urllib3. Ref pypa/setuptools#2465.
I've started working on generalizing the urllib3 technique in jaraco/tidelift#2, but I'm yet unsuccessful in substituting the project name, so could use some help there. |
This PR needs a rebase and here's the demo of solving the Tidelift problem: #2708. |
@pradyunsg plz rebase this — it should be unlocked now. |
I'll add a changelog entry, if we have agreement that this is the direction we want to take. :)