Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change documentation theme to Furo #2465

Merged
merged 6 commits into from
Jul 18, 2021
Merged

Conversation

pradyunsg
Copy link
Member

I'll add a changelog entry, if we have agreement that this is the direction we want to take. :)

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like the idea of having a unified docs theme across the PyPA projects.

@jaraco: The ToCs are removed because the furo theme adds its own ToC on each page, in the right sidebar, and is opinionated about not having it duplicated in the corresponding document body.

@pradyunsg: Is pradyunsg/furo@b6c7c76 released? If yes, you could close+reopen this PR to retrigger Netlify and have it build the preview.

@jaraco jaraco closed this Dec 6, 2020
@jaraco jaraco reopened this Dec 6, 2020
@jaraco
Copy link
Member

jaraco commented Dec 6, 2020

Is pradyunsg/furo@b6c7c76 released? If yes, you could close+reopen this PR to retrigger Netlify and have it build the preview.

I just closed, re-opened, and still had to manually re-deploy, but the error is emitted:

12:20:18 PM: Warning, treated as error:
12:20:18 PM: the furo extension does not declare if it is safe for parallel reading, assuming it isn't - please ask the extension author to check and make it explicit
ERROR: InvocationError for command /opt/build/repo/.tox/docs/bin/python -m sphinx -j auto -b html --color -a -n -W -d /opt/build/repo/.tox/.tmp/.doctrees . /opt/build/repo/build/html (exited with code 2)

That suggests the fix is not released. Also, that commit is not present in any tags.

@pradyunsg
Copy link
Member Author

@pradyunsg: Is pradyunsg/furo@b6c7c76 released? If yes, you could close+reopen this PR to retrigger Netlify and have it build the preview.

Not yet, no.

@jaraco jaraco changed the base branch from master to main December 12, 2020 17:16
@pradyunsg pradyunsg closed this Dec 15, 2020
@pradyunsg pradyunsg reopened this Dec 15, 2020
@pradyunsg
Copy link
Member Author

@jaraco Try redeploying now?

@webknjaz
Copy link
Member

webknjaz commented Dec 26, 2020

@pradyunsg looks like netlify doesn't do rebuilds on reopen. Try rebasing the PR.

@pradyunsg
Copy link
Member Author

This removed the tidelift contents from the sidebar.

It'd probably be a good idea to mimic how urllib3 handles the Tidelift callout: https://urllib3.readthedocs.io/en/latest/_sources/index.rst.txt, https://urllib3.readthedocs.io/en/latest/. Let me know if that's desirable and I'll amend this PR for that. :)

@jaraco
Copy link
Member

jaraco commented Dec 28, 2020

Happy to mimic urllib3. I'd like to apply the changes to every tidelift-sponsored project. Let's apply the concept to jaraco/tidelift first, then I can merge the change into setuptools main.

jaraco added a commit to jaraco/tidelift that referenced this pull request Dec 28, 2020
…ontents and borrow For Enterprise content from urllib3. Ref pypa/setuptools#2465.
@jaraco
Copy link
Member

jaraco commented Dec 28, 2020

I've started working on generalizing the urllib3 technique in jaraco/tidelift#2, but I'm yet unsuccessful in substituting the project name, so could use some help there.

@webknjaz
Copy link
Member

This PR needs a rebase and here's the demo of solving the Tidelift problem: #2708.

jaraco added a commit to jaraco/jaraco.tidelift that referenced this pull request Jul 18, 2021
@webknjaz
Copy link
Member

@pradyunsg plz rebase this — it should be unlocked now.

@jaraco jaraco marked this pull request as ready for review July 18, 2021 19:23
@jaraco jaraco merged commit d0d5a68 into pypa:main Jul 18, 2021
@pradyunsg pradyunsg deleted the change-docs-theme branch September 25, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants