-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group development related files together #2426
Conversation
In this case, the change to P.S. This probably deserves a change fragment: https://github.com/pypa/setuptools/tree/master/changelog.d. |
@alvyjudy the changelog is indeed optional for non-essential changes but it's my personal opinion that it's nice to have it most of the time. It's totally up to you, though. |
I've also noticed that |
@alvyjudy hey, my PR has been accepted and yours now has conflicts. I'm not planning to submit any more substantial changes in the near future so it's safe for you to solve the conflicts/do rebase. Please also note that you'll probably need to update the PR description to match what's actually in the PR ✌️ |
This change corrects the typo introduced by pypa#2426.
This is necessary because the document has been moved in PR pypa#2426.
This is necessary because the document has been moved in PR pypa#2426.
Summary of changes
Built on top of #2425 , I modified the file position for development related docs and referenced them from the top index:
Note: I think this means the github PR prompt will also have to be modified as it points toward the developer-guide ( https://setuptools.readthedocs.io/en/latest/developer-guide.html) that is now in a different position
Pull Request Checklist