New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.10 support to _distutils_hack #2361
Conversation
"import _distutils_hack" on Python 3.10 fails with:
The "abc" submodule must be imported from |
@vstinner This looks good to me, though it needs a news fragment. |
I added the Note: I failed to find a setuptools documentation explaining how to contribute to setuptools. I discovered that setuptools uses towncrier, but I failed to find a documentation explaining how to add a towncrier changelog entry :-( I'm used to blurb tool which opens a text editor and then creates the news entry. |
Get the 'Loader' abstract class from importlib.abc rather than importlib.util.abc (alias removed in Python 3.10).
Oh, thanks! It seems like "2361.bugfix.rst" is not an accepted filename, so I renamed it to "2361.change.rst". Is it better? I also squashed my commits. |
I may be interesting to mention https://setuptools.readthedocs.io/ and/or https://setuptools.readthedocs.io/en/latest/developer-guide.html in the README file. I can write a second PR for that, once this PR is merged. (I'm stupid and forgot to name my local branch, I abused the "master" branch. I prefer to wait until this PR is merged.) |
Yeah, it would probably also be a good idea to rename the incredibly similar-seeming "Developer's Guide" and "Developer's Guide for Setuptools": Probably that is best addressed as part of the #2093 revamp (though adding something to the README would be good too). It seems slightly easier in the latest iteration (though the confusing headings are still there, just more hidden). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'll probably rename the changelog from |
You're welcome. Good luck with fixing setuptools 50.0 regressions. I'm a strong supporter of burying distutils! So I will try to help to make it possible. |
…2062) setuptools 50.0.2 is now compatible with Python 3.10: pypa/setuptools#2361
…onGH-22062) setuptools 50.0.2 is now compatible with Python 3.10: pypa/setuptools#2361
Get the 'Loader' abstract class from importlib.abc rather than
importlib.util.abc (alias removed in Python 3.10).
Summary of changes
Closes
Pull Request Checklist