Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setuptools.txt #1938

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Update setuptools.txt #1938

merged 1 commit into from
Dec 31, 2019

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Dec 12, 2019

This PR:

  • uses the long option --upgrade consistently;
  • uses the built-in exec function instead of the Python 2-only execfile;
  • fixes a command typo installing setuptools and wheel twice instead of twine;
  • removes inconsistent --user options in some pip install commands;
  • calls pip install from the PATH consistently instead of from the module namespace (python -m pip install) as we are not upgrading pip itself on Windows anywhere;
  • fixes a URI.

@jaraco
Copy link
Member

jaraco commented Dec 31, 2019

Thank you very much for this gift.

@jaraco jaraco merged commit d95a7da into pypa:master Dec 31, 2019
@geryogam geryogam deleted the patch-1 branch January 1, 2020 02:53
@di di mentioned this pull request Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants