Remove "upload" and "register" commands. #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
force-pushed
the
remove_upload_register
branch
from
04a8273
to
c0bbd62
Compare
di
approved these changes
Oct 31, 2019
jaraco
approved these changes
Oct 31, 2019
pganssle
force-pushed
the
remove_upload_register
branch
4 times, most recently
from
1995daf
to
e5b43bd
Compare
|
Oops, turns out that if you name your classes Yet another time when I am appreciative that we include the tests in the coverage, and that we enforce diff coverage... |
pganssle
force-pushed
the
remove_upload_register
branch
from
e5b43bd
to
7703937
Compare
The upload and register commands were deprecated over a year ago, in July 2018 (PR pypaGH-1410, discussed in issue pypaGH-1381). It is time to actively remove them in favor of twine.
pganssle
force-pushed
the
remove_upload_register
branch
from
7703937
to
f413f95
Compare
|
OK, merging this, which means that next release should be a breaking one! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The upload and register commands were deprecated over a year ago, in July 2018 (PR #1410, discussed in issue #1381). It is time to actively remove them in favor of twine.
I think the most controversial part of this might be that I've added
setuptools.errors. It wasn't clear what the best error class to use would be.distutilswill useraise SystemExitfor a missing command; that didn't seem quite like the right thing to do, but I'm willing to be convinced otherwise.CC @pypa/setuptools-developers @di
Pull Request Checklist