-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python2 is broken after 41.5.0 [Windows] #1891
Comments
Does it work with this patch: setuptools/msvc.py | 1 +
1 file changed, 1 insertion(+)
diff --git i/setuptools/msvc.py w/setuptools/msvc.py
index ffa7053b..2ffe1c81 100644
--- i/setuptools/msvc.py
+++ w/setuptools/msvc.py
@@ -20,6 +20,7 @@
"""
import json
+from io import open
from os import listdir, pathsep
from os.path import join, isfile, isdir, dirname
import sys ? |
Yes, it will, that's one of the classic workarounds. I'd submit the PR... but I'm not sure how to add a test for that :S |
To clarify, the issue only occurs when building a package with a C extension? |
2 tasks
41.5.1 should be available shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In PR #1811 a non-python2 statement was introduced (
encoding
argument is not available in Python2):This breaks any installation in Windows py2 that requires to generate a package
The text was updated successfully, but these errors were encountered: