wheel: switch to packaging.tags for checking PEP 425 tags
#1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP until a new version of packaging including pypa/packaging#179 is released. |
benoit-pierre
force-pushed
the
update_pep425tags
branch
from
2c3941a
to
0744f7b
Compare
|
Updated now that packaging 19.2 has been released and ready for merge. |
2 tasks
skye
added a commit
to skye/jax
that referenced
this pull request
Aug 14, 2020
1. `wheel.pep425tags` has been removed as of pypa/setuptools#1829. Use the new `packaging.tags` instead. 2. Add `--allow-downgrades` to cuda install command. I'm not sure this is always necessary, but I ran into it, I'm guessing due to a cached docker image.
skye
added a commit
to google/jax
that referenced
this pull request
Sep 9, 2020
1. `wheel.pep425tags` has been removed as of pypa/setuptools#1829. Use the new `packaging.tags` instead. 2. Add `--allow-downgrades` to cuda install command. I'm not sure this is always necessary, but I ran into it, I'm guessing due to a cached docker image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Update setuptools vendored packaging so the wheel code can be switched to
packaging.tagsfor checking PEP 425 tags compatibility.Supersede #1822.
Closes #1799.
Pull Request Checklist