-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed html sidebars to supported version in Sphinx #1804
Conversation
4eac3e9
to
81e58e3
Compare
I have rebased this on #1802, since this is currently untested in the CI. |
Are we sure this is working correctly? The sidebar on the netlify preview looks different from the sidebar on the current documentation. The current documentation has "Next topic" and "This Page", both of which are missing in the netlify version. |
@pganssle well spotted it does not look right. I will have a look. |
@pganssle Little unsure what todo about the list method not being supported in older versions of Sphinx.
I could do something like:
Maybe i am miss reading the Sphenix documentation but it does not look like there is another way to declare the "value". |
@adamRogerson That doesn't seem right, Sphinx was raising deprecation warnings in version 1.8.5, so they must have had a migration target in mind. Are you sure the list version is not supported? The PR seems to be succeeding now and the netlify build (which uses |
@pganssle I must have misread the error there. Is there anything else that needs to be done on this ? |
Changed html_sidebars from single string to list of string as per
https://www.sphinx-doc.org/en/master/changes.html#id58
Closes #1565
Pull Request Checklist