Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why --lock-only flag logic removed? #6131

Open
Grommash9 opened this issue Apr 16, 2024 · 6 comments
Open

Why --lock-only flag logic removed? #6131

Grommash9 opened this issue Apr 16, 2024 · 6 comments
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged.

Comments

@Grommash9
Copy link

I can see in that commit:

6ac1451

The logic from flag lock-only was removed and now we have that flag but it is doing nothing at all, why? Should we fix that?

The sense of that flag is to not update the Pipfile if we don't want to include some packages in it

image

@Grommash9
Copy link
Author

image

How can I create MR? I am not able to create a branch

@matteius
Copy link
Member

The easier question first -- you'd have to fork to create a branch and open a PR.

IIRC correctly, the functionality was removed to fulfill the idea that all specifiers come from the Pipfile: #5818

The problem with something like --lock-only is it will get overwritten with the next lock if it doesn't originate from a Pipfile specifier.

@Grommash9
Copy link
Author

How can we update only one sub-dep package? For example idna for requests, I don't want to include it into Pipfile and I don't want to update all the packages, are we able to update only one?

I don't want to add sub-deps into Pipfile because at some point my packages can stop using them and I will be still installing that sub-deps for years

@Grommash9
Copy link
Author

An you can see on my photo I am trying to merge changes from my fork main into repo main

@matteius
Copy link
Member

I think the problem with --lock-only was that subsequent actions would revert back whatever sub-dependency without it originating from a proper specifier somewhere in the Pipfile. It could be added back, but I am not sure how one would account for that flaw.

@Grommash9
Copy link
Author

It would be amazing to add it back and maybe add a warning message? So people will know the consequences of using that flag. In my case it’s very useful and we even trying to use outdated version to use that flag

@matteius matteius added the Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged.
Projects
None yet
Development

No branches or pull requests

2 participants