Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2018.11.26 tagged at 2018.11.15.dev0 #3326

Closed
hroncok opened this issue Nov 29, 2018 · 4 comments · Fixed by #3298
Closed

2018.11.26 tagged at 2018.11.15.dev0 #3326

hroncok opened this issue Nov 29, 2018 · 4 comments · Fixed by #3298

Comments

@hroncok
Copy link
Contributor

hroncok commented Nov 29, 2018

As a Fedora packager, I take the tagged tarball from GitHub and want to package it, however the tagged version 2018.11.26 still has 2018.11.15.dev0 at https://github.com/pypa/pipenv/blob/742ae1b99b335ffb6d83a2240035af739cacafff/pipenv/__version__.py

Not sure if you are aware, probably not worth rereleasing.
@frostming
Copy link
Contributor

Thanks for the kind notice. /cc @techalchemy

@techalchemy
Copy link
Member

Yeah I saw this and forgot to reply -_- sorry! I replied in my head if that counts...

Yeah this is an annoying workflow issue and I need to sort out where in my release tooling it’s misbehaving. I obviously don’t check that during the release process...

techalchemy added a commit that referenced this issue Jan 22, 2019
@techalchemy
Update vendored dependency pins
ed3f206 
- Update gitignore entries for mypy config
- Update release task to add version after bumping but before release
- Fixes #3326 (going forward at least)
- Split out patching from vendoring so it can be done as a separate step
  if needed
- Update patches to account for updated packages
- Fixes #3432
- Fixes #2757
- Fixes #3305
- Fixes #2914
- Fixes #3439
- Fixes #3422
- Fixes #3378
- Fixes #3376
- Fixes #3315

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this issue Jan 22, 2019
Closed
@techalchemy techalchemy mentioned this issue Feb 26, 2019
Merged
@ghost
Copy link

ghost commented Nov 5, 2019 •
edited by ghost

The archive for 2018.11.26 still show version = "2018.11.15.dev0".
(The Arch package uses the archive link)

I'm wondering if that is just a tag issue or the if actual version is indeed 2018.11.15.dev0.
The thing is, I have this exact bug, supposed to be closed: #3287

EDIT: the commit from #3287 is indeed included in the archive so the version discrepancy is only a tagging issue, I guess.
Unfortunately that does not explain why I see the #3287 bug...

@homocomputeris
Copy link

#3098 seems to be more or less the same

@homocomputeris homocomputeris mentioned this issue Jan 26, 2020
Closed
joebonrichie pushed a commit to solus-packages/pipenv that referenced this issue Aug 15, 2023
@jamesl33 @DataDrake
Update pipenv to 2018.11.26
2cca63a 
Summary:
Updated pipenv to the latest release 2018.11.26.

Full changelog can be found [here](https://github.com/pypa/pipenv/blob/v2018.11.26/CHANGELOG.rst).

Test Plan:
When running pipenv version the output will be 'pipenv, version 2018.11.15.dev0'. This is a known issue and can be found [here](pypa/pipenv#3326).
Installed and tested several different operations including installing/uninstalling Python modules all of which worked as expected.

Reviewers: #triage_team, DataDrake

Reviewed By: #triage_team, DataDrake

Subscribers: DataDrake

Differential Revision: https://dev.getsol.us/D4683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix direct url dependency resolution pypa/pipenv
4 participants
@techalchemy @hroncok @homocomputeris @frostming