Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to self-invoke via directory on 3.6 #9883

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Fallback to self-invoke via directory on 3.6 #9883

merged 1 commit into from
Apr 29, 2021

Conversation

uranusjr
Copy link
Member

Fix #9878 (option 1).

@uranusjr
Fallback to self-invoke via directory on 3.6
f884203 
This fixes a compatibility issue when a PEP 517 build requirement
itself needs to be built in an isolated environment, caused by
importlib.resources not being available.
sbidoul
sbidoul approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note to self: understand how this works when pip is unbundled.

@sbidoul
Copy link
Member

sbidoul commented Apr 27, 2021

@uranusjr side note: as part of #9689, had you considered copying to a temp directory instead of a zip ?

@sbidoul sbidoul added this to the 21.1.1 milestone Apr 27, 2021
@uranusjr
Copy link
Member Author

That was discussed somewhere in the linked issue (the thread is looong) and IIRC the directory solution was rejected for being too slow.

@sbidoul
Copy link
Member

sbidoul commented Apr 29, 2021

This sounds like a reasonable tradeoff so merging.

@sbidoul sbidoul merged commit 999b121 into pypa:main Apr 29, 2021
@uranusjr uranusjr deleted the isolated-pip-py36-compat branch May 6, 2021 02:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbidoul sbidoul sbidoul approved these changes

@darrianussery7 darrianussery7 darrianussery7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.1.1
Development

Successfully merging this pull request may close these issues.

pip 21.1 install with --no-binary fails while 21.0.1 succeeds (pep517)
3 participants
@uranusjr @sbidoul @darrianussery7