Fix import error introduced in 21.1 #9835

jamescurtin · 2021-04-24T17:46:36Z

Fixes #9831 by guarding the import of NoReturn in a if TYPE_CHECKING: block because this type was only introduced in Python 3.6.2, but pip is compatible with Python >=3.6.0

pfmoore · 2021-04-24T18:00:47Z

.github/workflows/ci.yml

@@ -93,6 +93,7 @@ jobs:
      matrix:
        os: [Ubuntu, MacOS]
        python:
+          - 3.6.0


I like the idea here of pinning to 3.6.0 to make sure we don't regress, but doing so will (if I'm reading the docs correctly) result in 3.6.0 getting downloaded, rather than using the preinstalled version of 3.6. That will slow down our CI a bit, and we have an ongoing fight to speed up our CI. @pypa/pip-committers awhat do you think? Is this worthwhile?

Also, we really don't need both 3.6.0 and 3.6...

More than happy to remove this if you're comfortable. I added it as a way to demonstrate that this patch resolves the issue, but perhaps the value is outweighed by the interest in speeding up CI.

I like the idea in principle, but let's see what the other committers think.

You could have scheduled pipelines where you enable such configuration(s).. ?

pfmoore · 2021-04-24T18:09:08Z

Also, it looks like black wants to mess with the changed code 🙁

pradyunsg · 2021-04-24T18:17:11Z

Also, it looks like black wants to mess with the changed code 🙁

Not black, isort.

From our documentation:

pip works with CPython versions 3.6, 3.7, 3.8, 3.9 and also PyPy.

This means pip works on the latest patch version of each of these minor versions. Previous patch versions are supported on a best effort approach.

We explicitly state that we support the latest patch version releases of CPython versions and other versions are on a best-effort basis. I'm definitely a strong -1 on adding 3.6.0 to our CI.

I'm a bit bleh on this PR overall TBH. I don't think this fix is worth making unless it's a quick bugfix release and we're yanking the 21.1 release because of this issue. And... Well, I don't think this is worth doing that much churn anyway?

pradyunsg · 2021-04-24T18:17:53Z

Anyway, that doesn't work either:

Error: Version 3.6.0 with arch x64 not found

jamescurtin · 2021-04-24T18:41:02Z

We explicitly state that we support the latest patch version releases of CPython versions and other versions are on a best-effort basis. I'm definitely a strong -1 on adding 3.6.0 to our CI.

Thanks for the feedback on that: I have removed it.

I'm a bit bleh on this PR overall TBH. I don't think this fix is worth making unless it's a quick bugfix release and we're yanking the 21.1 release because of this issue. And... Well, I don't think this is worth doing that much churn anyway?

Based on the principle that previous patch versions are supported on a "best effort" basis, it seems that resolving this regression would be reasonable. If the maintainers felt strongly about not wanting to make this patch, I'd advocate for updating setup.py to set the minimum Python version to 3.6.2.

Thoughts?

pradyunsg · 2021-04-24T18:53:27Z

I'm personally not going to be doing anything for < 3.6.2 support.

Honestly, I couldn't care less about what we do here. 3.6.2 is from 2017 (https://www.python.org/dev/peps/pep-0494/#id1), we explicitly state that the supported Python versions are the latest patch version. Any support for significantly older versions is kindness for folks on those older versions, and I have other things to do that I care about more.

I only said something here because there were changes to the CI for guaranteeing something we explicitly state the opposite of in our documentation. That change wouldn't have worked anyway, so I'm gonna shut up now. :)

pradyunsg · 2021-04-24T18:55:56Z

That said, I'm not the only maintainer here, so if some other maintainer does have any interest in fixing this, I'm not going to be blocking them. :)

jamescurtin · 2021-04-24T20:02:01Z

@pfmoore (or other maintainers):

Is there any interest in reviewing and accepting this PR such that pip is compatible with all patch versions of 3.6?

sbidoul · 2021-04-24T20:37:21Z

I'm personally not opposed to merging this.

I'd add a comment explaining why NoReturn is under TYPE_CHECKING, so it is not accidentally removed. Can you also squash the commits?

However, I'm not sure this alone warrants a bugfix release.

uranusjr · 2021-04-24T20:53:46Z

+1 to merging this. We probably have a need for a patch release anyway (for the headers mismatch thing) and this fixes a real issue (albeit edge case) with virtually zero downsides.

jamescurtin · 2021-04-24T21:00:27Z

I'm personally not opposed to merging this.

I'd add a comment explaining why NoReturn is under TYPE_CHECKING, so it is not accidentally removed. Can you also squash the commits?

However, I'm not sure this alone warrants a bugfix release.

Done--thank you for taking a look!

pfmoore · 2021-04-24T22:36:24Z

I see no harm in merging it, so I've approved. But I'll leave the merge to someone else.

By the way, this thing were I have to approve every CI run for a new contributor, not just the first one, is a complete pain in the a***. (But I'm not blaming you, @jamescurtin, just to be clear!)

sbidoul · 2021-04-25T09:37:44Z

Thank you @jamescurtin

sergiitk · 2021-04-26T18:42:37Z

Thank you for fixing this! May I ask when is it expected to be released? As I understand, this is going out in 21.1.1. grpc/grpc has a few buildscripts running tests with python 3.6.1, and now they're broken. Just to understand whether to pin to the previous release, or wait until 21.1.1 is released.

maciejkula · 2021-04-26T18:57:48Z

+1 for a speedy release (and thank you for the fix)!

…oo large. Work around pypa/pip#9835. PiperOrigin-RevId: 370472029

…oo large. Work around pypa/pip#9835. PiperOrigin-RevId: 370560208

pradyunsg · 2021-04-27T06:19:37Z

I suggest subscribing to #9761 for release-related updates. Please be mindful about making comments there though, since lots of folks have subscribed to that issue for release-related updates.

Issue is get_pip.py is moved to pip 21.1 (https://github.com/pypa/get-pip/commits/main) which is not compatible with 3.6. Issue of pip itself is fixed as part of 21.1.1 in pip community (pypa/pip#9835). However get-pip.py is still not updated to latest pip. Also get.pip.py does not support python 3.6 version explicitly (pypa/get-pip#88) Step 15/29 : RUN curl https://bootstrap.pypa.io/get-pip.py | python3.6 ---> Running in bece31f49267 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 1891k 100 1891k 0 0 9564k 0 --:--:-- --:--:-- --:--:-- 9600k Traceback (most recent call last): File "<stdin>", line 24298, in <module> File "<stdin>", line 139, in main File "<stdin>", line 115, in bootstrap File "<stdin>", line 96, in monkeypatch_for_cert File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/commands/__init__.py", line 9, in <module> File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/cli/base_command.py", line 12, in <module> File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/cli/cmdoptions.py", line 30, in <module> File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/utils/hashes.py", line 2, in <module> ImportError: cannot import name 'NoReturn' The command '/bin/sh -c curl https://bootstrap.pypa.io/get-pip.py | python3.6' returned a non-zero code: 1 How I did: Got the file from https://github.com/pypa/get-pip/tree/21.0 and added to the buildimage pin pip to the previous release 21.0.1. (Similar is done in other public repos eg: grpc/grpc-java#8115) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

* [build] Fix the snmp docker build error. (#7452) Issue is get_pip.py is moved to pip 21.1 (https://github.com/pypa/get-pip/commits/main) which is not compatible with 3.6. Issue of pip itself is fixed as part of 21.1.1 in pip community (pypa/pip#9835). However get-pip.py is still not updated to latest pip. Also get.pip.py does not support python 3.6 version explicitly (pypa/get-pip#88) Step 15/29 : RUN curl https://bootstrap.pypa.io/get-pip.py | python3.6 ---> Running in bece31f49267 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 1891k 100 1891k 0 0 9564k 0 --:--:-- --:--:-- --:--:-- 9600k Traceback (most recent call last): File "<stdin>", line 24298, in <module> File "<stdin>", line 139, in main File "<stdin>", line 115, in bootstrap File "<stdin>", line 96, in monkeypatch_for_cert File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/commands/__init__.py", line 9, in <module> File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/cli/base_command.py", line 12, in <module> File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/cli/cmdoptions.py", line 30, in <module> File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/utils/hashes.py", line 2, in <module> ImportError: cannot import name 'NoReturn' The command '/bin/sh -c curl https://bootstrap.pypa.io/get-pip.py | python3.6' returned a non-zero code: 1 How I did: Got the file from https://github.com/pypa/get-pip/tree/21.0 and added to the buildimage pin pip to the previous release 21.0.1. (Similar is done in other public repos eg: grpc/grpc-java#8115) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

PiperOrigin-RevId: 371166775 Change-Id: I111e81557f0129841e6bdd7c63b0e2b03be595fc

Issue is get_pip.py is moved to pip 21.1 (https://github.com/pypa/get-pip/commits/main) which is not compatible with 3.6. Issue of pip itself is fixed as part of 21.1.1 in pip community (pypa/pip#9835). However get-pip.py is still not updated to latest pip. Also get.pip.py does not support python 3.6 version explicitly (pypa/get-pip#88) Step 15/29 : RUN curl https://bootstrap.pypa.io/get-pip.py | python3.6 ---> Running in bece31f49267 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 1891k 100 1891k 0 0 9564k 0 --:--:-- --:--:-- --:--:-- 9600k Traceback (most recent call last): File "<stdin>", line 24298, in <module> File "<stdin>", line 139, in main File "<stdin>", line 115, in bootstrap File "<stdin>", line 96, in monkeypatch_for_cert File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/commands/__init__.py", line 9, in <module> File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/cli/base_command.py", line 12, in <module> File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/cli/cmdoptions.py", line 30, in <module> File "/tmp/tmp5fnxrz0a/pip.zip/pip/_internal/utils/hashes.py", line 2, in <module> ImportError: cannot import name 'NoReturn' The command '/bin/sh -c curl https://bootstrap.pypa.io/get-pip.py | python3.6' returned a non-zero code: 1 How I did: Got the file from https://github.com/pypa/get-pip/tree/21.0 and added to the buildimage pin pip to the previous release 21.0.1. (Similar is done in other public repos eg: grpc/grpc-java#8115) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

pfmoore reviewed Apr 24, 2021

View reviewed changes

Fix import error introduced in 21.1

6d63690

jamescurtin force-pushed the 9831-bugfix branch from cb4969f to 6d63690 Compare April 24, 2021 20:55

uranusjr approved these changes Apr 24, 2021

View reviewed changes

pfmoore approved these changes Apr 24, 2021

View reviewed changes

sbidoul added this to the 21.1.1 milestone Apr 25, 2021

sbidoul merged commit 7a77484 into pypa:main Apr 25, 2021

jamescurtin deleted the 9831-bugfix branch April 25, 2021 12:13

sergiitk mentioned this pull request Apr 26, 2021

buildscripts: xds-k8s pin pip to 21.0.1 grpc/grpc#26087

Merged

pfmoore mentioned this pull request Apr 26, 2021

pip crashes on python 3.6.1 with "cannot import name 'NoReturn'" #9879

Closed

1 task

sergiitk mentioned this pull request Apr 26, 2021

buildscripts: xds-k8s pin pip to 21.0.1 grpc/grpc-java#8115

Merged

copybara-service bot pushed a commit to tensorflow/recommenders that referenced this pull request Apr 26, 2021

Do not raise an exception when projection dim in the Cross layer is t…

929584f

…oo large. Work around pypa/pip#9835. PiperOrigin-RevId: 370472029

copybara-service bot mentioned this pull request Apr 26, 2021

Do not raise an exception when projection dim in the Cross layer is too large. tensorflow/recommenders#281

Merged

copybara-service bot pushed a commit to tensorflow/recommenders that referenced this pull request Apr 26, 2021

Do not raise an exception when projection dim in the Cross layer is t…

4f10e7b

…oo large. Work around pypa/pip#9835. PiperOrigin-RevId: 370560208

abdosi mentioned this pull request Apr 28, 2021

[buildfix-201911] Fix the snmp docker build error. sonic-net/sonic-buildimage#7452

Merged

lguohan mentioned this pull request Apr 28, 2021

[build] Fix the snmp docker build error. (#7452) sonic-net/sonic-buildimage#7459

Merged

4 tasks

copybara-service bot pushed a commit to google-deepmind/dm-haiku that referenced this pull request Apr 29, 2021

Pin pip because of pypa/pip#9835.

7e5522a

PiperOrigin-RevId: 371166775 Change-Id: I111e81557f0129841e6bdd7c63b0e2b03be595fc

edmorley mentioned this pull request Apr 29, 2021

pip uses typing.NoReturn which is new in 3.6.2 #9921

Closed

plannigan mentioned this pull request Jul 26, 2021

v21.2 does not run on Python 3.6.0 & Python 3.6.1 #10211

Closed

1 task

github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix import error introduced in 21.1 #9835

Fix import error introduced in 21.1 #9835

jamescurtin commented Apr 24, 2021

pfmoore Apr 24, 2021

jamescurtin Apr 24, 2021

pfmoore Apr 24, 2021

gst Apr 27, 2021

pfmoore commented Apr 24, 2021

pradyunsg commented Apr 24, 2021 •

edited

pradyunsg commented Apr 24, 2021

jamescurtin commented Apr 24, 2021 •

edited

pradyunsg commented Apr 24, 2021 •

edited

pradyunsg commented Apr 24, 2021 •

edited

jamescurtin commented Apr 24, 2021

sbidoul commented Apr 24, 2021

uranusjr commented Apr 24, 2021

jamescurtin commented Apr 24, 2021

pfmoore commented Apr 24, 2021

sbidoul commented Apr 25, 2021

sergiitk commented Apr 26, 2021

maciejkula commented Apr 26, 2021

pradyunsg commented Apr 27, 2021

Fix import error introduced in 21.1 #9835

Fix import error introduced in 21.1 #9835

Conversation

jamescurtin commented Apr 24, 2021

pfmoore Apr 24, 2021

Choose a reason for hiding this comment

jamescurtin Apr 24, 2021

Choose a reason for hiding this comment

pfmoore Apr 24, 2021

Choose a reason for hiding this comment

gst Apr 27, 2021

Choose a reason for hiding this comment

pfmoore commented Apr 24, 2021

pradyunsg commented Apr 24, 2021 • edited

pradyunsg commented Apr 24, 2021

jamescurtin commented Apr 24, 2021 • edited

pradyunsg commented Apr 24, 2021 • edited

pradyunsg commented Apr 24, 2021 • edited

jamescurtin commented Apr 24, 2021

sbidoul commented Apr 24, 2021

uranusjr commented Apr 24, 2021

jamescurtin commented Apr 24, 2021

pfmoore commented Apr 24, 2021

sbidoul commented Apr 25, 2021

sergiitk commented Apr 26, 2021

maciejkula commented Apr 26, 2021

pradyunsg commented Apr 27, 2021

pradyunsg commented Apr 24, 2021 •

edited

jamescurtin commented Apr 24, 2021 •

edited

pradyunsg commented Apr 24, 2021 •

edited

pradyunsg commented Apr 24, 2021 •

edited