Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to packaging 20.9 #9533

Merged
merged 1 commit into from Jan 30, 2021
Merged

Conversation

henryiii
Copy link
Contributor

Ran with vendoring sync . -v.

Preparation for #9506; fixes an issue with pip not installing 10.9+ Universal2 wheels on ARM macOS.

@pfmoore
Copy link
Member

pfmoore commented Jan 29, 2021

Thanks. What's with the "chore:" in the commit message and PR title? As an entirely trivial style point (i.e. if you don't I won't worry) I'd prefer if it were omitted.

@henryiii
Copy link
Contributor Author

Habit, from https://www.conventionalcommits.org/en/v1.0.0/ - chore being for updates.

@henryiii
Copy link
Contributor Author

Should I bump everything from pipenv run nox -s vendoring -- --upgrade ? It ran fine on macOS, there are 4 bumps:

Upgrade urllib3 to 1.26.3
Upgrade idna to 3.1
Upgrade certifi to 2020.12.5
Upgrade packaging to 20.9

@henryiii
Copy link
Contributor Author

henryiii commented Jan 29, 2021

Nice, it even adds the news entries. :)

@henryiii
Copy link
Contributor Author

Next time I'm using pipx, seems like nox -s vendoring wants to add my Pipfile/Pipfile.lock.

@henryiii henryiii changed the title chore: update to packaging 20.9 Update to packaging 20.9 Jan 29, 2021
@henryiii
Copy link
Contributor Author

I've cherry picked one commit from the four (and removed the Pipfiles it added to the commit 😠 ). Rerunning with pipx run nox -s vendoring -- --upgrade was much better, didn't add extra files - I can switch to the four commits if you'd rather everything bumped. Or I can do separate PRs, if you prefer everything bumped but one-per-PR.

@pfmoore
Copy link
Member

pfmoore commented Jan 29, 2021

Sorry, I don't have time to look at this, maybe one of the other @pypa/pip-committers does.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust vendoring is doing the right thing and did not check the updated code in packaging, only the file names affected.

@pfmoore pfmoore merged commit 00fb5a0 into pypa:master Jan 30, 2021
@pradyunsg
Copy link
Member

LGTM!

Next time I'm using pipx, seems like nox -s vendoring wants to add my Pipfile/Pipfile.lock.

The automation is written with the assumption that you have a clean working tree. 🤷🏻‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants