Improve deprecation warnings #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
type: enhancement
pradyunsg
force-pushed
the
improve-deprecation-warnings
branch
from
b20c8d1
to
2ff13e4
Compare
xavfernandez
approved these changes
May 27, 2019
|
Thanks for the review @xavfernandez! :D |
|
I'll merge this now. @cjerdonek I hope you don't mind that; I'll be happy to hear suggestions from you on this, if you have any. :) |
I made review comments on the original PR you filed. I don't know if you addressed them here or not. |
|
I did. :) Except for the one on the error message changing based on error vs warning, for which I made #6218 (comment). |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6216
Supercedes #6218