Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use declarative setup.cfg #6501

Closed
venthur opened this issue May 14, 2019 · 3 comments
Closed

Use declarative setup.cfg #6501

venthur opened this issue May 14, 2019 · 3 comments
Labels
state: needs discussion This needs some more discussion type: refactor Refactoring code

Comments

@venthur
Copy link
Contributor

venthur commented May 14, 2019

What's the problem this feature will solve?

Setuptools allows for a more declarative setup.cfg instead of having lots of stuff in setup.py

Describe the solution you'd like

Move most of the stuff from setup.py to setup.cfg

Alternative Solutions

Additional context

@pradyunsg pradyunsg added state: needs discussion This needs some more discussion type: refactor Refactoring code labels May 19, 2019
@pradyunsg
Copy link
Member

Thanks for filing this issue @venthur! This is a great idea but now is not the right time to do this IMO.

There are still quite a few users on older systems that upgrade to newer pip versions from them and this change would render them incapable of doing so. That'll mean figuring out the amount of such use (installing pip from older version of pip). I haven't looked at the numbers (would have to write an SQL query for BigQuery) but would imagine there's quite a few folks who do that.

Even if that's a low occurrence case though, I still don't think we should do this right now. This isn't all that painful in any way for the maintainers/users and pip's "churn budget" is pretty low given the growing pains of rolling out PEP 517; spending it on a change which does not provide much functional value to us wouldn't be great.

Slightly OT: FWIW, I want to even move pip over to a different build backend (away from setuptools) if something easier/nicer shows up, but it's a little early in the PEP 517 adoption curve to do that.

@ichard26
Copy link
Member

And pip now uses setuptools' pyproject.toml support and doesn't even have a setup.py or setup.cfg sooo this can be closed :)

@pfmoore pfmoore closed this as completed Mar 13, 2024
@ichard26
Copy link
Member

@pfmoore if you feel like pressing more buttons, here are two more issues that can be closed:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
state: needs discussion This needs some more discussion type: refactor Refactoring code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants