Enable importlib.metadata backend on Python 3.11 #11044
Conversation
uranusjr
force-pushed
the
importlib-metadata-backend-in-3.11
branch
from
a1986d9
to
c07ae74
Compare
| @@ -219,11 +219,12 @@ jobs: | |||
| env: | |||
| TEMP: "R:\\Temp" | |||
|
|
|||
| # TODO: Remove this when we add Python 3.11 to CI. | |||
There was a problem hiding this comment.
We can do this now FWIW, 3.11.0-alpha - 3.11?
There was a problem hiding this comment.
Ah, it’s a bit difficult to convert 3.11.0-alpha.7 to 3.11 for nox -s test-{{ python }}…
There was a problem hiding this comment.
You can use the include field to add an additional key-value to the 3.11.0-alpha.7 entry -> https://github.com/cooperlees/black-primer/blob/6c40328df33f72468105466423edd2115be491ff/.github/workflows/ci.yaml#L30-L35 and then use a OR expression -> https://github.com/cooperlees/black-primer/blob/6c40328df33f72468105466423edd2115be491ff/.github/workflows/ci.yaml#L53
There was a problem hiding this comment.
Ah, this is the syntax I was looking for, thanks
${{ matrix.nox-python || matrix.python }}
There was a problem hiding this comment.
Seem like it’s not ready for virtualenv (which we need for Nox) unfortunately
ERROR: The executable /home/runner/work/pip/pip/.nox/test-3-11/bin/python3.11 is not functioning
ERROR: It thinks sys.prefix is '/opt/hostedtoolcache/Python/3.11.0-alpha.7/x64' (should be '/home/runner/work/pip/pip/.nox/test-3-11')
ERROR: virtualenv is not compatible with this system or executable
Running virtualenv with interpreter /opt/hostedtoolcache/Python/3.11.0-alpha.7/x64/bin/python3.11
There was a problem hiding this comment.
Yea, we're stuck on virtualenv 16.x for our test suite. That's now a proper problem. :)
uranusjr
force-pushed
the
importlib-metadata-backend-in-3.11
branch
4 times, most recently
from
a176c5e
to
c07ae74
Compare
github-actions
bot
added
the
needs rebase or merge
|
@uranusjr Let's rebase this and get this released this week, before the Python 3.11 betas begin? |
uranusjr
force-pushed
the
importlib-metadata-backend-in-3.11
branch
2 times, most recently
from
b0f754f
to
930d68e
Compare
|
So... it looks like we didn't get this into beta1. Are we comfortable making a change to how Python 3.11+ behaves in a pip release immediately after the beta period has started? |
|
@uranusjr nudge nudge. This is currently blocking 22.1. |
|
Sorry I’m attending another conference this week; might get some time to get this in later today. |
uranusjr
force-pushed
the
importlib-metadata-backend-in-3.11
branch
from
930d68e
to
bd9bcef
Compare
With 3.11 beta coming out next month, we can get this ready for testing.
Similar to the sysconfig transition, this builds in some hidden switches for downstream distributors to use, in case they need it. (see #10647)