Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 22.0.1 #10850

Merged
merged 2 commits into from Jan 30, 2022
Merged

Release 22.0.1 #10850

merged 2 commits into from Jan 30, 2022

Conversation

pradyunsg
Copy link
Member

Toward #10726

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 30, 2022
@pradyunsg pradyunsg merged commit cc35c93 into pypa:main Jan 30, 2022
@pradyunsg pradyunsg deleted the release/22.0.1 branch January 30, 2022 19:43
@oktep
Copy link

oktep commented Jan 30, 2022 •
edited

Why are you checking whether it is <!DOCTYPE HTML> ? So far there was no need, to check it. There is issue on Azure DevOps, where repository don't start with <!DOCTYPE HTML> but <HTML> is first tag. As in the previous comment, there are a lot of other issues and many other edge cases which you cannot cover.

@pradyunsg
Copy link
Member Author

@oktep Please go to #10825. Commenting on random PRs is not going to make it more likely that you'd get a constructive response.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pradyunsg @oktep