Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip vulnerability reports that are marked as "withdrawn" #385

Closed
woodruffw opened this issue Oct 20, 2022 · 5 comments · Fixed by #386
Closed

Skip vulnerability reports that are marked as "withdrawn" #385

woodruffw opened this issue Oct 20, 2022 · 5 comments · Fixed by #386
Assignees
@woodruffw
Labels
component:vuln-sources Components that provide sources of vulnerability information enhancement New feature or request

Comments

@woodruffw
Copy link
Member

The OSV format supports the withdrawn field, which indicates that a report has been withdrawn and is no longer valid.

pip-audit should respect that field and ignore any reports that contain it, so long as the field's timestamp is not after the current time.
@woodruffw woodruffw added the enhancement New feature or request label Oct 20, 2022
@woodruffw woodruffw self-assigned this Oct 20, 2022
@woodruffw
Copy link
Member Author

This applies immediately to the OSV service backend, but may also apply to PyPI's vulnerability DB (which serves a functional subset of the OSV schema). I'll need to check what PyPI's updated does when a entry is marked as withdrawn.

@woodruffw woodruffw added the component:vuln-sources Components that provide sources of vulnerability information label Oct 20, 2022
@woodruffw
Copy link
Member Author

(I identified this as part of looking into pytest-dev/py#287 -- we "correctly" report this spam vulnerability at the moment because it isn't marked as withdrawn yet, but we should skip it if/when it's correctly withdrawn.)

@jenstroeger jenstroeger mentioned this issue Oct 20, 2022
Open
@woodruffw woodruffw mentioned this issue Oct 22, 2022
Merged
@di
Copy link
Sponsor Member

di commented Oct 24, 2022

#386 looks good to me but I think we should probably extend support for this to PyPI as well -- shall we create a separate issue for tracking that?

@woodruffw
Copy link
Member Author

Yeah, I think so -- I can create that in a moment.

@harshavamsi harshavamsi mentioned this issue Oct 24, 2022
Closed
@woodruffw woodruffw mentioned this issue Oct 25, 2022
Closed
@woodruffw
Copy link
Member Author

#388 is the continuation of this, for PyPI's vulnerability service.

@jenstroeger jenstroeger mentioned this issue Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
component:vuln-sources Components that provide sources of vulnerability information enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

osv: skip results marked as "withdrawn" pypa/pip-audit
2 participants
@di @woodruffw