From b8e573965a33de78f89fb0595ca4410ed34a5ff6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Bidoul?= Date: Sat, 4 Jun 2022 13:11:20 +0200 Subject: [PATCH] Do not set extra in default_environment PEP 508 says explicitly that the presence of extra in an environment except in special cases. --- packaging/markers.py | 2 +- tests/test_markers.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packaging/markers.py b/packaging/markers.py index 031658b5..978b1763 100644 --- a/packaging/markers.py +++ b/packaging/markers.py @@ -269,7 +269,6 @@ def default_environment() -> Dict[str, str]: iver = format_full_version(sys.implementation.version) implementation_name = sys.implementation.name return { - "extra": "", "implementation_name": implementation_name, "implementation_version": iver, "os_name": os.name, @@ -335,6 +334,7 @@ def evaluate(self, environment: Optional[Dict[str, str]] = None) -> bool: The environment is determined from the current Python process. """ current_environment = default_environment() + current_environment["extra"] = "" if environment is not None: current_environment.update(environment) diff --git a/tests/test_markers.py b/tests/test_markers.py index ca574b1b..e943e492 100644 --- a/tests/test_markers.py +++ b/tests/test_markers.py @@ -109,7 +109,6 @@ def test_matches_expected(self): ) assert environment == { - "extra": "", "implementation_name": sys.implementation.name, "implementation_version": iver, "os_name": os.name,