Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prerelease detection for > and < #794

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix prerelease detection for > and < #794

wants to merge 2 commits into from
+4 −3

Conversation

notatallshaw
Copy link

@notatallshaw notatallshaw commented Apr 13, 2024 •
edited

Fixes #788

And adds an explicit test for != based on #776 (comment)

This was referenced Apr 13, 2024
Open
Closed
Open
@notatallshaw
Copy link
Author

Feedback would be appreciated.

@uranusjr
Copy link
Member

And adds an explicit test for !=

Is this for another PR? I don’t see the change here.

@notatallshaw
Copy link
Author

notatallshaw commented May 20, 2024 •
edited

And adds an explicit test for !=

Is this for another PR? I don’t see the change here.

It's in this PR, it's in the change to tests/test_specifiers.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specifier < that contains prerelease version does not match on valid prerelease versions
2 participants
@notatallshaw @uranusjr