New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does version.parse
still have a purpose?
#679
Comments
FWIW using |
Calling Version directly is totally OK. I don't expect we'd be enforcing a change to that in any way. |
No, because it has ~0 cost and consumers needing to change their calls is unnecessary churn IMO. |
That's fine, but the docs are a bit ambiguous. Grice's maxims come into play here and if the docs give me two different ways of doing something, I automatically assume that they are not equivalent. This is probably the case for most humans :). Would you be open to adding this to the
|
#597 would likely involve covering this, so a PR making any level of progress toward that would be welcome! |
Currently
parse
boils down to the following one-liner:Is there still any future usecase for it, or is it just a leftover from
LegacyVersion
times that one can now avoid, and useVersion
directly instead? Are there any plans to deprecate it?Docs do not specify whether one is preferred over another, but right now it seems like
parse
is just redundant function call overhead.I understand the need to preserve
parse
in its current form for API stability, but it would be nice to indicate which one is future-proof / whether one can callVersion(...)
directly and not have to worry about any additions to the spec being implemented outside of it.The text was updated successfully, but these errors were encountered: