Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up manylinux tests and musllinux manifest #438

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

uranusjr
Copy link
Member

Unifying code structuring differences between manylinux and musllinux so they can be maintained more easily together.

  1. Manylinux logic is separated into a private module _manylinux like musllinux. This makes packaging.tags a bit more maintainable, it was almost 800 lines previously.
  2. Some manylinux tests are split into test_manylinux.py for the same reason.
  3. Binaries used in manylinux tests are moved into a subdirectory (similar to how musllinux tests’ binaries are located); previously they were pretty randomly placed in the tests’ root directory.
  4. Tidy up MANIFEST.in to include musllinux tests’ binaries in the sdist.

@brettcannon
Copy link
Member

We should probably get this merged before we cut a 21.0 release.

@brettcannon brettcannon merged commit d650cfd into pypa:main Jul 1, 2021
@brettcannon
Copy link
Member

Thanks!

@uranusjr uranusjr deleted the refactor-elf-detection branch July 2, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants