types: pass through filter list type #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This passes through the type of a list in filter.
Example:
x: typing.List[Version]
reveal_type(SpecifierSet("*").filter(x))
Before:
Revealed type is 'typing.Iterable[Union[packaging.version.Version, packaging.version.LegacyVersion, builtins.str]]'
After:
Revealed type is 'typing.Iterable[packaging.version.Version*]'
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
types/passthroughfilter
branch
from
256b7bc
to
96a4a8c
Compare
|
This is the current workaround: unsorted_versions = cast(Iterable[Version], spec.filter(versions))which is really ugly, since versions is known to be an iterable of Version's only. |
pradyunsg
approved these changes
May 28, 2021
brettcannon
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes through the type of an iterable in filter.
filternever broadens or changes the types of the input list.Example:
Before:
After: