Document version classes comparison behaviour #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
requested changes
Apr 24, 2020
brettcannon
requested changes
Apr 24, 2020
deveshks
force-pushed
the
version-classes-doc
branch
2 times, most recently
from
8e49df9
to
fab8974
Compare
deveshks
force-pushed
the
version-classes-doc
branch
from
fab8974
to
e4ce04b
Compare
the tests are passing now 😊 |
pradyunsg
approved these changes
Apr 25, 2020
brettcannon
approved these changes
Apr 27, 2020
|
Thanks @deveshks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and closes #216
Document how version classes
VersionandLegacyVersionbehave when compared, and address how some version strings with specific words/characters in the end are still valid PEP-440 strings