Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twine-upload: fix tense on password nudge #234

Open
wants to merge 1 commit into
base: unstable/v1
Choose a base branch
from
Open

twine-upload: fix tense on password nudge #234

wants to merge 1 commit into from

Conversation

woodruffw
Copy link
Member

This also makes the password case a hard error on pypi.org, since we know it's going to fail. But I'm happy to revert that if you'd prefer to display the error and let twine upload fail instead 馃檪

Fixes #233

@woodruffw
twine-upload: fix tense on password nudge
1fa98bf 
Also makes password use a hard error on PyPI.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

Interesting CI failure:

Traceback (most recent call last):
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/bin/flake8", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 375, in run
    self._run(argv)
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 363, in _run
    self.initialize(argv)
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 343, in initialize
    self.find_plugins(config_finder)
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 157, in find_plugins
    self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 363, in __init__
    self.manager = PluginManager(
                   ^^^^^^^^^^^^^^
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 243, in __init__
    self._load_entrypoint_plugins()
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 261, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'EntryPoints' object has no attribute 'get'

@webknjaz
Copy link
Member

@woodruffw that's because of the Python 3.11->3.12 bump in pre-commit.ci. I'll fix that separately, it's already on my radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TODO] Update the 2FA nudge error message to use present tense
2 participants
@woodruffw @webknjaz